[
https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871351#action_12871351
]
HBase Review Board commented on HBASE-2578:
-------------------------------------------
Message from: "Daniel Ploeg" <[email protected]>
Thanks Todd.
- I'm modifying the HowToContribute page and didn't see a reference to the
inclusion of the license header there or on the Code review page. I haven't
committed my next change to the HowToContribute page yet, so I'm adding a
reference there (plus modifying my files).
- The singleton approach I think might be better. I thought that having the
instance variable smelled a bit, that's why I asked about the fixed overhead.
I'll make some changes.
- IncrementingEE - I'll make some sync type changes here.
I'll upload a new patch later today with these changes.
- Daniel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review56
-----------------------------------------------------------
On 2010-05-25 12:40:01, Daniel Ploeg wrote:
> Add ability for tests to override server-side timestamp setting
> (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2578
> URL: https://issues.apache.org/jira/browse/HBASE-2578
> Project: HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Daniel Ploeg
> Attachments: HBASE-2578.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps. This
> creates weird timing issues with tests running on different systems because
> sometimes a set of operations happens in the same millisecond and other times
> they do not.
> We should have a way for a test to specify it's own way of generating the
> timestamps (for example, could always increment by 1 ensuring forward
> progression in time).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
