[
https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871362#action_12871362
]
HBase Review Board commented on HBASE-2578:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review65
-----------------------------------------------------------
Ship it!
Implementation is well done. The need for this though strikes me as odd. So
I'm +1 on the patch but let me go comment up on the bigger issue I see up in
the JIRA.
- stack
> Add ability for tests to override server-side timestamp setting
> (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2578
> URL: https://issues.apache.org/jira/browse/HBASE-2578
> Project: HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Daniel Ploeg
> Attachments: HBASE-2578.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps. This
> creates weird timing issues with tests running on different systems because
> sometimes a set of operations happens in the same millisecond and other times
> they do not.
> We should have a way for a test to specify it's own way of generating the
> timestamps (for example, could always increment by 1 ensuring forward
> progression in time).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
