[
https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871355#action_12871355
]
HBase Review Board commented on HBASE-2578:
-------------------------------------------
Message from: "Ryan Rawson" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review62
-----------------------------------------------------------
What other possible approaches could we take to solving this issue? I seem to
recalling a different strategy but I cannot recall it right now. We are really
not set up for DI right now, and the ultimate direction of this patch is a
fully dependency injected solution.
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/83/#comment345>
this seems overly HRegion specific - what is the "standard" mechanism for
providing mocked out systems level time-based replacements?
src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java
<http://review.hbase.org/r/83/#comment344>
lets not use assertEquals(String,int,int) and just use
assertEquals(int,int).
- Ryan
> Add ability for tests to override server-side timestamp setting
> (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2578
> URL: https://issues.apache.org/jira/browse/HBASE-2578
> Project: HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Daniel Ploeg
> Attachments: HBASE-2578.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps. This
> creates weird timing issues with tests running on different systems because
> sometimes a set of operations happens in the same millisecond and other times
> they do not.
> We should have a way for a test to specify it's own way of generating the
> timestamps (for example, could always increment by 1 ensuring forward
> progression in time).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
