[
https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872728#action_12872728
]
HBase Review Board commented on HBASE-2578:
-------------------------------------------
Message from: "Ryan Rawson" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review88
-----------------------------------------------------------
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
<http://review.hbase.org/r/83/#comment510>
I'm thinking perhaps a Static interface could be used instead of the
getDelegate().currentTimeMillis() that way the individual call sites could say:
EnvironmentEdge.currentTimeMillis()
instead of
System.currentTimeMillis()
but the static calls would be a simple wrapper around the existing
getDelegate mechanisms... this would just make the code more explicit and
easier to follow for future generations.
OTher than that, looking great! Thanks for making all the changes!
- Ryan
> Add ability for tests to override server-side timestamp setting
> (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2578
> URL: https://issues.apache.org/jira/browse/HBASE-2578
> Project: HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Daniel Ploeg
> Fix For: 0.21.0
>
> Attachments: HBASE-2578.txt, HBASE-2578_take2.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps. This
> creates weird timing issues with tests running on different systems because
> sometimes a set of operations happens in the same millisecond and other times
> they do not.
> We should have a way for a test to specify it's own way of generating the
> timestamps (for example, could always increment by 1 ensuring forward
> progression in time).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
