[
https://issues.apache.org/jira/browse/HBASE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873787#action_12873787
]
HBase Review Board commented on HBASE-2578:
-------------------------------------------
Message from: "Daniel Ploeg" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/
-----------------------------------------------------------
(Updated 2010-05-31 14:18:59.665128)
Review request for hbase.
Changes
-------
Changed easymock to mockito :)
Summary
-------
HBASE-2578 - Add ability for tests to override server-side timestamp setting
(currentTimeMillis).
The solution in this patch ensures that tests use a different timestamp with a
minimal change to the production code paths.
One question I would like to know is whether the change that was made to
HRegion.FIXED_OVERHEAD would cause any other side effects.
This addresses bug HBASE-2578.
http://issues.apache.org/jira/browse/HBASE-2578
Diffs (updated)
-----
pom.xml 0a009cf
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48
src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
PRE-CREATION
src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6
src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
PRE-CREATION
src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java
PRE-CREATION
Diff: http://review.hbase.org/r/83/diff
Testing
-------
Thanks,
Daniel
> Add ability for tests to override server-side timestamp setting
> (currentTimeMillis)
> -----------------------------------------------------------------------------------
>
> Key: HBASE-2578
> URL: https://issues.apache.org/jira/browse/HBASE-2578
> Project: HBase
> Issue Type: Improvement
> Reporter: Jonathan Gray
> Assignee: Daniel Ploeg
> Fix For: 0.21.0
>
> Attachments: HBASE-2578.txt, HBASE-2578_final.txt,
> HBASE-2578_take2.txt
>
>
> Many of our tests use client APIs which do not set explicit stamps. This
> creates weird timing issues with tests running on different systems because
> sometimes a set of operations happens in the same millisecond and other times
> they do not.
> We should have a way for a test to specify it's own way of generating the
> timestamps (for example, could always increment by 1 ensuring forward
> progression in time).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
