[
https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876055#action_12876055
]
HBase Review Board commented on HBASE-2400:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review137
-----------------------------------------------------------
This looks great Hammer. No major comments.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment721>
No. Setting a timestamp actually just sets the timerange with (stamp,
stamp+1)
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment722>
I've seen this in other places like HMaster where sometimes we initialize
through command-line and other times programatically within something else,
like in tests or to re-initialize... I think
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment723>
This is one thing that is fairly mixed in the codebase. Not sure which is
the right way, I like things spaced out but I might be in the minority.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment724>
This is unfortunately mixed a bit... I think the client APIs say TimeStamp,
not sure why exactly but I guess just align with that?
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment725>
The form I believe we follow is that inputs can be either null or 0-length
array, but that data returned is a 0-length array. Would need to verify this
is always the case but I think it is.
- Jonathan
> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
> Key: HBASE-2400
> URL: https://issues.apache.org/jira/browse/HBASE-2400
> Project: HBase
> Issue Type: Task
> Components: avro
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift
> connector, but using Avro serialization and associated transport and RPC
> server work. Support AAA (audit, authentication, authorization).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
