[
https://issues.apache.org/jira/browse/HBASE-2400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876063#action_12876063
]
HBase Review Board commented on HBASE-2400:
-------------------------------------------
Message from: "Andrew Purtell" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/128/#review138
-----------------------------------------------------------
Looks good Jeff. Some missing functionality IMHO. See my individual comments.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment726>
That would be good.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment727>
No split()?
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroServer.java
<http://review.hbase.org/r/128/#comment728>
Export exists() to the client.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment729>
Really appreciate this, which will help out with Avro encoding support in
the REST interface. We should find a way for all of the connectors to share
common Avro, Thrift, and Protobuf packages. I will refactor the protobuf stuff
soon.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment730>
Yes. And all of the connectors should drop such requests, throw exceptions,
and warn upon similar events.
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment731>
Or just handle this generically as a string?
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment732>
Or just handle this generically as a string?
trunk/src/main/java/org/apache/hadoop/hbase/avro/AvroUtil.java
<http://review.hbase.org/r/128/#comment733>
0-length array.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment734>
See comment on AvroServer in this regard.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment735>
How do you deal with user attributes? A column can have an arbitrary set of
them. Coprocessors will use this facility. Not necessary to support attribute
access via fields of the descriptors if there are RPC methods available to read
or write them.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment736>
Likewise, no support for user attributes here.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment737>
No support for filters. For REST, the model classes recursively walk the
filter structure and build a JSON representation that is then passed as a
string.
No support for setBatch()
Consider support for setCacheBlocks() (regionserver level caching) and
setCaching() (connector level caching)?
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment738>
Missing split()
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment739>
Missing attribute get and set, if not supporting read/write access via
descriptor structs.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment740>
Missing attribute get and set, if not supporting read/write access via
descriptor structs.
trunk/src/main/java/org/apache/hadoop/hbase/avro/hbase.genavro
<http://review.hbase.org/r/128/#comment741>
Missing exists()
- Andrew
> new connector for Avro RPC access to HBase cluster
> --------------------------------------------------
>
> Key: HBASE-2400
> URL: https://issues.apache.org/jira/browse/HBASE-2400
> Project: HBase
> Issue Type: Task
> Components: avro
> Reporter: Andrew Purtell
> Priority: Minor
> Attachments: HBASE-2400-v0.patch
>
>
> Build a new connector contrib architecturally equivalent to the Thrift
> connector, but using Avro serialization and associated transport and RPC
> server work. Support AAA (audit, authentication, authorization).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
