[
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877720#action_12877720
]
HBase Review Board commented on HBASE-2618:
-------------------------------------------
Message from: "Benoit Sigoure" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/
-----------------------------------------------------------
(Updated 2010-06-10 22:30:11.419078)
Review request for hbase.
Changes
-------
Patch rebased on trunk HEAD.
Also I found out that I missed some files. The code still compiled because the
unchanged files weren't recompiled and some weird exception was thrown at
runtime due to the fact that half of the files were compiled at the time where
HConstants was an interface etc. Yay maven... Wasn't it supposed to be better
than `make? OK, no comment.
Now the code compiles after a `mvn clean' (which deletes the `target'
directory) and I tested it yesterday and today. Also all the weird failures
"NoServerForRegionException: Timed out trying to locate root region because:
Failed setting up proxy" disappeared. Sounds like one needs to "make clean
all" to get a build that works, and we're in 2010.
Summary
-------
HBASE-2618 Don't inherit from HConstants.
Bonus: minor aesthetic / coding style clean ups and minor code changes.
This addresses bug HBASE-2618.
http://issues.apache.org/jira/browse/HBASE-2618
Diffs (updated)
-----
trunk/src/main/java/org/apache/hadoop/hbase/HConstants.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/HMerge.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/client/MetaScanner.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/master/BaseScanner.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ChangeTableState.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ColumnOperation.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ModifyTableMeta.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ProcessRegionOpen.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/RegionManager.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/master/RegionServerOperation.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/RegionServerOperationQueue.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/master/TableOperation.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/HQuorumPeer.java 953529
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKServerTool.java
953529
trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 953529
trunk/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java 953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetDeleteTracker.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanDeleteTracker.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestWildcardColumnTracker.java
953529
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java
953529
Diff: http://review.hbase.org/r/132/diff
Testing
-------
Code compiles.
Tests are acting up on my machine right now (many of them fail with a weird
message [1] and Todd says he's been seeing similar failures for some time
already, so I guess I'll try to run them again next week when the New Moon
arrives).
[1] A number of tests fail with:
org.apache.hadoop.hbase.client.NoServerForRegionException: Timed out trying to
locate root region because: Failed setting up proxy to /192.168.0.7:63773 after
attempts=1
at
org.apache.hadoop.hbase.client.HConnectionManager$TableServers.locateRootRegion(HConnectionManager.java:1031)
Where, of course, 192.168.0.7 is my IP address.
Some of the tests that are acting up:
org.apache.hadoop.hbase.TestZooKeeper,
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling,
org.apache.hadoop.hbase.rest.TestScannersWithFilters,
org.apache.hadoop.hbase.master.TestMasterWrongRS,
org.apache.hadoop.hbase.thrift.TestThriftServer,
org.apache.hadoop.hbase.master.TestMasterTransitions,
org.apache.hadoop.hbase.rest.TestStatusResource,
org.apache.hadoop.hbase.client.TestFromClientSide,
org.apache.hadoop.hbase.TestMultiParallelPut,
org.apache.hadoop.hbase.master.TestRegionManager,
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
Thanks,
Benoit
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad
> pattern and is recommended against in many places including Effective Java
> (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
