[ 
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12877345#action_12877345
 ] 

HBase Review Board commented on HBASE-2618:
-------------------------------------------

Message from: "Benoit Sigoure" <[email protected]>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review173
-----------------------------------------------------------


Can we apply this patch now?

- Benoit





> Don't inherit from HConstants
> -----------------------------
>
>                 Key: HBASE-2618
>                 URL: https://issues.apache.org/jira/browse/HBASE-2618
>             Project: HBase
>          Issue Type: Wish
>            Reporter: Benoit Sigoure
>            Assignee: Benoit Sigoure
>            Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants?  This is a known bad 
> pattern and is recommended against in many places including Effective Java 
> (item 17).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to