[
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876735#action_12876735
]
HBase Review Board commented on HBASE-2618:
-------------------------------------------
Message from: "Benoit Sigoure" <[email protected]>
bq. On 2010-06-08 08:41:36, Jonathan Gray wrote:
bq. > trunk/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java, line
243
bq. > <http://review.hbase.org/r/132/diff/2/?file=1028#file1028line243>
bq. >
bq. > This seems to change behavior. Looks like it would previously
default to local if not set, now will default to non local?
Oops, that wasn't my intention here. Thanks for catching this!
bq. On 2010-06-08 08:41:36, Jonathan Gray wrote:
bq. >
trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java,
line 1696
bq. > <http://review.hbase.org/r/132/diff/2/?file=1039#file1039line1696>
bq. >
bq. > From this point forward in the diff, it looks like a majority of the
changes are whitespace. Not saying you need to throw it out but it's making
this long patch even longer :)
Consider this a regression of HBASE-2518 – but I don't feel like filing another
JIRA for this silly issue. I don't understand why people keep adding trailing
whitespaces to the code.
bq. On 2010-06-08 08:41:36, Jonathan Gray wrote:
bq. >
trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestQueryMatcher.java,
line 38
bq. > <http://review.hbase.org/r/132/diff/2/?file=1052#file1052line38>
bq. >
bq. > I guess there were a few tests that implemented HConstants but
didn't actually use anything in there? Maybe was before HBaseTestCase
That's my guess too. Old cruft.
- Benoit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review155
-----------------------------------------------------------
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad
> pattern and is recommended against in many places including Effective Java
> (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
