[
https://issues.apache.org/jira/browse/HBASE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12876383#action_12876383
]
HBase Review Board commented on HBASE-2618:
-------------------------------------------
Message from: "Ryan Rawson" <[email protected]>
bq. On 2010-06-06 09:08:19, Jonathan Gray wrote:
bq. > This patch changes a bunch of tabbing patterns to be different from what
is currently done in the codebase. Primarily the full indenting of arguments
to align with each other.
bq. >
bq. > As far as I know, this format is not used anywhere else in HBase. I
don't think patches to clean up HConstants inheriting should do a partial
change to a different style for something unrelated?
bq.
bq. Benoit Sigoure wrote:
bq. As far as I can tell HBase doesn't seem to follow any consistent
coding style, so I did what everyone else seems to be doing, I let my editor do
the re-indenting the way I typically do.
bq. I'll upload a new patch with the indentation change.
bq.
bq. Other than that, what do you think about the change?
bq.
bq. Jonathan Gray wrote:
bq. It is mostly consistent. In general the practice is to keep the same
styling as the file you're in or if a new file, in whatever else is like it
that's already there.
bq.
bq. Other than that, I'm a big +1 on removing the extending interface
pattern we use on HConstants and your patch looks good to me on that front.
bq.
bq. Jonathan Gray wrote:
bq. As far as the tests go, I've never actually seen that failing pattern.
I've been running unit tests on trunk in at least 4 different environments.
bq.
bq. I wonder where this is coming from... Is there a jira open for this
specific failure? If not, let's open one so we can get to the bottom of it.
I have noticed that HBase is mostly K&R with a continuation indent not
alignment. It tends to match the IntelliJ default code style with tabs=2,
continuation-indent=4. Perhaps tweak your editor to only use align-braces on
method parameters (as per IJ) and do continuation indent on all others.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/132/#review135
-----------------------------------------------------------
> Don't inherit from HConstants
> -----------------------------
>
> Key: HBASE-2618
> URL: https://issues.apache.org/jira/browse/HBASE-2618
> Project: HBase
> Issue Type: Wish
> Reporter: Benoit Sigoure
> Assignee: Benoit Sigoure
> Priority: Minor
>
> Can we stop using this idiom to inherit from HConstants? This is a known bad
> pattern and is recommended against in many places including Effective Java
> (item 17).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
