[
https://issues.apache.org/jira/browse/HBASE-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891868#action_12891868
]
HBase Review Board commented on HBASE-2697:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/382/
-----------------------------------------------------------
(Updated 2010-07-23 16:28:15.057431)
Review request for hbase, stack, Jean-Daniel Cryans, Karthik Ranganathan, and
Kannan Muthukkaruppan.
Changes
-------
Whitespace take 2
Summary
-------
This method implements all the zookeeper methods needed for this last part of
the doc posted in HBASE-2692 (definition of valid creation/transitions for
unassigned znodes):
MASTER
1. Master creates an unassigned node as OFFLINE.
- Cluster startup and table enabling.
2. Master forces an existing unassigned node to OFFLINE.
- RegionServer failure.
- Allows transitions from all states to OFFLINE.
3. Master deletes an unassigned node that was in a OPENED state.
- Normal region transitions. Besides cluster startup, no other deletions
of unassigned nodes is allowed.
4. Master deletes all unassigned nodes regardless of state.
- Cluster startup before any assignment happens.
REGIONSERVER
1. RegionServer creates an unassigned node as CLOSING.
- All region closes will do this in response to a CLOSE RPC from Master.
- A node can never be transitioned to CLOSING, only created.
2. RegionServer transitions an unassigned node from CLOSING to CLOSED.
- Normal region closes. CAS operation.
3. RegionServer transitions an unassigned node from OFFLINE to OPENING.
- All region opens will do this in response to an OPEN RPC from the Master.
- Normal region opens. CAS operation.
4. RegionServer transitions an unassigned node from OPENING to OPENED.
- Normal region opens. CAS operation.
This addresses bug HBASE-2697.
http://issues.apache.org/jira/browse/HBASE-2697
Diffs (updated)
-----
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
PRE-CREATION
Diff: http://review.hbase.org/r/382/diff
Testing
-------
Unit test to come. Just putting up since there have been some recent issues
with multiple transitions and stuff, wanted to show what the new stuff looks
like.
Thanks,
Jonathan
> Implement new open/close logic in handlers and stop using heartbeats for
> open/close messages
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-2697
> URL: https://issues.apache.org/jira/browse/HBASE-2697
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, regionserver
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> This issue is doing the meat of what HBASE-2485 is about and continues what
> was started in HBASE-2694 after some code cleanup to make life easier.
> This deals with no longer piggybacking messages from Master to RegionServers
> on heartbeat responses and instead sending direct unsolicited messages. This
> also deals with moving the open/close logic fully into handlers and removing
> the existing open/close code on both the RS and M sides. There may also be
> some changes to the master in-memory state of regions in transition. The new
> load balancer will probably be introduced with this issue but not fully
> integrated yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
