[
https://issues.apache.org/jira/browse/HBASE-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892848#action_12892848
]
HBase Review Board commented on HBASE-2697:
-------------------------------------------
Message from: [email protected]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/382/#review498
-----------------------------------------------------------
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2019>
Put your big doc up here in class comment? Or you want to make a document
of it? Or you want me to do it for you?
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2016>
The way this method is named would seem to imply it does something
internally that has to do w/ 'offlining' but all I see is the createAndWatch
and passing of whatever is in data.getBytes(). It makes me think this method
is not properly scoped -- that it should be doing more?
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2017>
Great javadoc.
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2018>
I have the same issue w/ this method. You are passing in the 'generic'
RegionTransitionData type which seems like it could be anything?
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2020>
This method is same as createNodeOffline but for the log message. As said
above, it makes me think the method should be broader
branches/0.90_master_rewrite/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
<http://review.hbase.org/r/382/#comment2021>
Whats in the 'data' passed in here?
- stack
> Implement new open/close logic in handlers and stop using heartbeats for
> open/close messages
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-2697
> URL: https://issues.apache.org/jira/browse/HBASE-2697
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, regionserver
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> This issue is doing the meat of what HBASE-2485 is about and continues what
> was started in HBASE-2694 after some code cleanup to make life easier.
> This deals with no longer piggybacking messages from Master to RegionServers
> on heartbeat responses and instead sending direct unsolicited messages. This
> also deals with moving the open/close logic fully into handlers and removing
> the existing open/close code on both the RS and M sides. There may also be
> some changes to the master in-memory state of regions in transition. The new
> load balancer will probably be introduced with this issue but not fully
> integrated yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
