[
https://issues.apache.org/jira/browse/HBASE-2697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891871#action_12891871
]
HBase Review Board commented on HBASE-2697:
-------------------------------------------
Message from: "Jonathan Gray" <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/382/#review476
-----------------------------------------------------------
Thinking on it, I will probably need to not just blindly force something to
OFFLINE in the masters force to OFFLINE. Though any state will be able to be
transitioned to OFFLINE (during recovery, we may need to restart the assignment
of something, setting to OFFLINE first is what allows us to timeout if for some
reason an RS doesn't respond/act on an OPEN rpc), we will want to use more of a
CAS operation so we don't accidentally miss a transition on that node.
For example, we may timeout an OFFLINE because it took too long, so we want to
switch it back to a new version of OFFLINE and assign to someone else. We'll
want to ensure when setting to OFFLINE it's still in the previously seen
OFFLINE version, otherwise a server may have started OPENING in between our
check and set.
- Jonathan
> Implement new open/close logic in handlers and stop using heartbeats for
> open/close messages
> --------------------------------------------------------------------------------------------
>
> Key: HBASE-2697
> URL: https://issues.apache.org/jira/browse/HBASE-2697
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, regionserver
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Priority: Critical
> Fix For: 0.90.0
>
>
> This issue is doing the meat of what HBASE-2485 is about and continues what
> was started in HBASE-2694 after some code cleanup to make life easier.
> This deals with no longer piggybacking messages from Master to RegionServers
> on heartbeat responses and instead sending direct unsolicited messages. This
> also deals with moving the open/close logic fully into handlers and removing
> the existing open/close code on both the RS and M sides. There may also be
> some changes to the master in-memory state of regions in transition. The new
> load balancer will probably be introduced with this issue but not fully
> integrated yet.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
