[
https://issues.apache.org/jira/browse/HBASE-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696115#comment-13696115
]
Lars George commented on HBASE-8774:
------------------------------------
Hi [~madani], thanks for your continued help with this.
bq. Do you want me to create a patch out of HBASE-6073 to close the scanner
when there are no result or do you think with HBASE-3852, that's unnecessary ?
That is something we need to figure out. How about we document the partial
patch of HBASE-6073 in HBASE-3852 and then close the former as superseded by
HBASE-3852 and HBASE-8774?
bq. I added a third parameter to getScannerRows to close the scanner as soon
as it gets the result.
I think that is a interesting option to offer to clients. But I also think this
might warrant a separate call to show the distinction. Although we can make
that optional and therefore keep one call. I actually tend to the latter having
just iterated over both solutions.
bq. Re-generate TScan and TGet files with Thrift 0.9. Updated formatting as
well.
Oh good idea :) What formatting did you update BTW?
bq. I have added attribute to scan , get , delete , increment and put. do you
want me to update this patch or make a new one base on current trunk ?
Please see HBASE-8832, I think that is what you are referring to? Please add a
patch of off trunk, we can merge the changes one after the other. And attach
the patch over there please. Good on you Hamed!
> Add BatchSize and Filter to Thrift2
> -----------------------------------
>
> Key: HBASE-8774
> URL: https://issues.apache.org/jira/browse/HBASE-8774
> Project: HBase
> Issue Type: Sub-task
> Components: Thrift
> Affects Versions: 0.95.1
> Reporter: Hamed Madani
> Assignee: Hamed Madani
> Labels: thrift2
> Attachments: HBASE_8774.patch, HBASE_8774_v2.patch
>
>
> Attached Patch will add BatchSize and Filter support to Thrift2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
