[
https://issues.apache.org/jira/browse/HBASE-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696200#comment-13696200
]
Hamed Madani commented on HBASE-8774:
-------------------------------------
Thank you [~larsgeorge], you are right about the Text type. I doubled check and
as you suggested, changed filterString type to binary. updated the patch
As for HBASE-8832 , I have to wait for this patch to get applied to trunk
because, I have added "attribute" to struct definitions in hbase.thrift file
and if we apply this patch, we have to create a new patch for HBASE-8832 with
new numbering in hbase.thrift file. To clarify, if I create a patch for
"attribute" right now the TScan struct's number for "attribute" will be *7*,
but if I create the HBASE-8832 patch after applying HBASE-8774 patch , the
"attribute" number will be "*9:* optional map<binary, binary> attributes"
{code}
struct TScan {
1: optional binary startRow,
2: optional binary stopRow,
3: optional list<TColumn> columns
4: optional i32 caching,
5: optional i32 maxVersions=1,
6: optional TTimeRange timeRange,
*7:* optional binary filterString,
*8:* optional i32 batchSize
}
{code}
I did not apply formatting to generated files (hence lines longer than 100
characters) because if I apply formatting to these files , it will make
applying the future patches to these auto-generated files non-trivial. If you
like me to apply formatting to generated files , please let me know. (
formatting I mentioned for patch_v2 was for *ThriftUtilities.java*)
> Add BatchSize and Filter to Thrift2
> -----------------------------------
>
> Key: HBASE-8774
> URL: https://issues.apache.org/jira/browse/HBASE-8774
> Project: HBase
> Issue Type: Sub-task
> Components: Thrift
> Affects Versions: 0.95.1
> Reporter: Hamed Madani
> Assignee: Hamed Madani
> Labels: thrift2
> Attachments: HBASE_8774.patch, HBASE_8774_v2.patch,
> HBASE_8774_v3.patch
>
>
> Attached Patch will add BatchSize and Filter support to Thrift2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
