[
https://issues.apache.org/jira/browse/HBASE-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994506#comment-13994506
]
Matteo Bertozzi commented on HBASE-11139:
-----------------------------------------
yes, the TestMultiParallel failure is not related to your patch. don't worry.
The test looks almost good, but the test will pass even without the patch.
If instead of queue.poll() you use queue.poll(1000, TimeoutUnit.MILLISECONDS)
and add @Test(timeout=10000) in testPollInExecutor() you should be probably
good to go.
> BoundedPriorityBlockingQueue#poll() should check the return value from
> awaitNanos()
> -----------------------------------------------------------------------------------
>
> Key: HBASE-11139
> URL: https://issues.apache.org/jira/browse/HBASE-11139
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.99.0
> Reporter: Ted Yu
> Assignee: Shengzhe Yao
> Priority: Minor
> Labels: noob
> Attachments: HBASE-11139-v1.patch, HBASE-11139-v2.patch
>
>
> nanos represents the timeout value.
> {code}
> while (queue.size() == 0 && nanos > 0) {
> notEmpty.awaitNanos(nanos);
> }
> {code}
> The return value from awaitNanos() should be checked - otherwise we may wait
> for period longer than the timeout value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
