[ 
https://issues.apache.org/jira/browse/HBASE-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994673#comment-13994673
 ] 

Hadoop QA commented on HBASE-11139:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12644348/HBASE-11139-v3.patch
  against trunk revision .
  ATTACHMENT ID: 12644348

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.master.TestAssignmentManagerOnCluster

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9500//console

This message is automatically generated.

> BoundedPriorityBlockingQueue#poll() should check the return value from 
> awaitNanos()
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-11139
>                 URL: https://issues.apache.org/jira/browse/HBASE-11139
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Ted Yu
>            Assignee: Shengzhe Yao
>            Priority: Minor
>              Labels: noob
>         Attachments: HBASE-11139-v1.patch, HBASE-11139-v2.patch, 
> HBASE-11139-v3.patch, HBASE-11139-v4.patch
>
>
> nanos represents the timeout value.
> {code}
>       while (queue.size() == 0 && nanos > 0) {
>         notEmpty.awaitNanos(nanos);
>       }
> {code}
> The return value from awaitNanos() should be checked - otherwise we may wait 
> for period longer than the timeout value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to