[ 
https://issues.apache.org/jira/browse/HBASE-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993998#comment-13993998
 ] 

Matteo Bertozzi commented on HBASE-11139:
-----------------------------------------

[~ipodfans] Thanks for the patch!
since the code is not used anywhere can you add a unittest to 
TestBoundedPriorityBlockingQueue

> BoundedPriorityBlockingQueue#poll() should check the return value from 
> awaitNanos()
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-11139
>                 URL: https://issues.apache.org/jira/browse/HBASE-11139
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.99.0
>            Reporter: Ted Yu
>            Priority: Minor
>              Labels: noob
>         Attachments: HBASE-11139-v1.patch
>
>
> nanos represents the timeout value.
> {code}
>       while (queue.size() == 0 && nanos > 0) {
>         notEmpty.awaitNanos(nanos);
>       }
> {code}
> The return value from awaitNanos() should be checked - otherwise we may wait 
> for period longer than the timeout value.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to