[ 
https://issues.apache.org/jira/browse/HBASE-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256806#comment-14256806
 ] 

Matteo Bertozzi commented on HBASE-12749:
-----------------------------------------

HFileLink is supposed to be a link to an HFile not to a Snapshot the 
"table=region-hfile" has no idea about snapshots, but it just a pointer to an 
HFile. so stuff like HFileLink.createFromSnapshotFileLink() in 
ServerRegionReplicaUtil do not make sense, because you are not creating a link 
from a snapshot but you are just referencing an hfile somewhere. so the 
hfilelink is already being used on non-snapshot files.



> Tighten HFileLink api to enable non-snapshot uses
> -------------------------------------------------
>
>                 Key: HBASE-12749
>                 URL: https://issues.apache.org/jira/browse/HBASE-12749
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0, 1.1.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>         Attachments: hbase-12749.patch
>
>
> In HBASE-12332 we'd like to use the FileLink's IO redirecting powers but want 
> to be able to specify arbitrary alternate link paths and not be tied to the 
> SnapshotFileLink file pattern (aka, table=region-hfile).  
> To do this we need change the constructors and some internals so that it is 
> more generic.  Along the way, we remove the FileStatus constructor arguments 
> in favor of Path's and reduce the number of ways to create HFileLinks, and 
> tighten up the scope privacy of many methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to