[
https://issues.apache.org/jira/browse/HBASE-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256883#comment-14256883
]
Matteo Bertozzi commented on HBASE-12749:
-----------------------------------------
{quote}Ok, Is the concern the only name or is there more?{quote}
the only other concern is the removed FileStatus from the StoreInfo and the
addition of the FileSystem, but I still have to figure out why is that
necessary.
{quote}Do you have an alternative name? How is "HfileLinkPattern" or
"HfileLInkPatternPath"{quote}
both sounds good to me.
{quote}Really the HFileLink constructor/creator method should just have this
signature instead of only being able to that the funny path.
HFileLink.create(conf, TableName, String regionEncName, String familyName,
String hfileName)
{quote}
sounds good, it wasn't clear to me from the jira description what was the
purpose of this patch. you throw me off with that snapshot thing. but the
problem is basically that the only way to create an hfileLink is to create the
fancy name first 'table=region-hfile' and then create an hfileLink from there
(like the ServerRegionReplicaUtil is doing). You can add/use the new
"constructor" in this patch for ServerRegionReplicaUtil as example.
> Tighten HFileLink api to enable non-snapshot uses
> -------------------------------------------------
>
> Key: HBASE-12749
> URL: https://issues.apache.org/jira/browse/HBASE-12749
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-12749.patch
>
>
> In HBASE-12332 we'd like to use the FileLink's IO redirecting powers but want
> to be able to specify arbitrary alternate link paths and not be tied to the
> SnapshotFileLink file pattern (aka, table=region-hfile).
> To do this we need change the constructors and some internals so that it is
> more generic. Along the way, we remove the FileStatus constructor arguments
> in favor of Path's and reduce the number of ways to create HFileLinks, and
> tighten up the scope privacy of many methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
