[
https://issues.apache.org/jira/browse/HBASE-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256911#comment-14256911
]
Jonathan Hsieh commented on HBASE-12749:
----------------------------------------
bq. the only other concern is the removed FileStatus from the StoreInfo and the
addition of the FileSystem, but I still have to figure out why is that
necessary.
check out HBASE-12332. We don't have a FileStatus to attach to in that
particular case initially. In the snapshot case we have the pattern file and
get a fileStatus, and in the replicas case we have a file status as well[1]
The fs was needed for StoreFileInfo#getFileStatus (and getModificaitonTime) and
StoreFile.Reader#open. Probably can just as easily as of a FS in
StoreFileInfo#getFileStatus. Didn't tackle those pieces yet (they also seem
more tightly coupled than ideal)
[1]
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java#L186
> Tighten HFileLink api to enable non-snapshot uses
> -------------------------------------------------
>
> Key: HBASE-12749
> URL: https://issues.apache.org/jira/browse/HBASE-12749
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-12749.patch
>
>
> In HBASE-12332 we'd like to use the FileLink's IO redirecting powers but want
> to be able to specify arbitrary alternate link paths and not be tied to the
> SnapshotFileLink file pattern (aka, table=region-hfile).
> To do this we need change the constructors and some internals so that it is
> more generic. Along the way, we remove the FileStatus constructor arguments
> in favor of Path's and reduce the number of ways to create HFileLinks, and
> tighten up the scope privacy of many methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
