[
https://issues.apache.org/jira/browse/HBASE-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14256865#comment-14256865
]
Jonathan Hsieh commented on HBASE-12749:
----------------------------------------
Ok, Is the concern the only name or is there more? Do you have an alternative
name? How is "HfileLinkPattern" or "HfileLInkPatternPath"
Over in HBASE-12332 we create hfilelink's that have the redirection
capabilities but essentially set arbitrary alternate paths in the constructor
without having the 'table=region-hfile' file present (what I've called the
"snapshot link file"). I'm trying to capture that idea the file of the pattern
table=region-hfile present is an artifact specific to clones of snapshotted
tables.
In the ServerRegionReplicaUtil instance, you are right -- the code is creating
a fake path in the table=region-hfile pattern -- which seems a little strange
to me.
Really the HFileLink constructor/creator method should just have this signature
instead of only being able to that the funny path.
HFileLink.create(conf, TableName, String regionEncName, String familyName,
String hfileName)
> Tighten HFileLink api to enable non-snapshot uses
> -------------------------------------------------
>
> Key: HBASE-12749
> URL: https://issues.apache.org/jira/browse/HBASE-12749
> Project: HBase
> Issue Type: Bug
> Components: snapshots
> Affects Versions: 2.0.0, 1.1.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-12749.patch
>
>
> In HBASE-12332 we'd like to use the FileLink's IO redirecting powers but want
> to be able to specify arbitrary alternate link paths and not be tied to the
> SnapshotFileLink file pattern (aka, table=region-hfile).
> To do this we need change the constructors and some internals so that it is
> more generic. Along the way, we remove the FileStatus constructor arguments
> in favor of Path's and reduce the number of ways to create HFileLinks, and
> tighten up the scope privacy of many methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
