[
https://issues.apache.org/jira/browse/HBASE-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583915#comment-14583915
]
Hadoop QA commented on HBASE-13893:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12739276/HBASE-13893.patch
against master branch at commit 47a9ff5d1f4f90fe9ddc05a478cca0d4f82fd30a.
ATTACHMENT ID: 12739276
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 330
new or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+ * @see org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)
+ * {@link org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)}
+ * @see org.apache.hadoop.hbase.client.Table#coprocessorService(Class,
byte[], byte[], org.apache.hadoop.hbase.client.coprocessor.Batch.Call)
+ // HBaseAdmin only waits for regions to appear in hbase:meta we should
wait until they are assigned
+ public Table truncateTable(final TableName tableName, final boolean
preserveRegions) throws IOException {
+ assertTrue("Delta " + delta + " for family " + index + " should
be at least deltaForLargestFamily " + deltaForLargestFamily,
+ TableName.valueOf("testHTableExistsMethodSingleRegionSingleGet"),
new byte[][] { FAMILY });
+ new String[] {"getCtPreWALRestore", "getCtPostWALRestore",
"getCtPrePut", "getCtPostPut",
+ new String[] {"getCtPreWALRestore", "getCtPostWALRestore",
"getCtPrePut", "getCtPostPut",
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
org.apache.hadoop.hbase.security.access.TestAccessController
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpointNoMaster
org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas
org.apache.hadoop.hbase.client.TestSnapshotFromClient
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
org.apache.hadoop.hbase.client.TestReplicaWithCluster
org.apache.hadoop.hbase.client.TestReplicasClient
org.apache.hadoop.hbase.client.TestClientPushback
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testSplitWithRegionReplicas(TestSplitTransactionOnCluster.java:690)
at
org.apache.hadoop.hbase.coprocessor.TestMasterObserver.testTableOperations(TestMasterObserver.java:1420)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14388//testReport/
Release Findbugs (version 2.0.3) warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14388//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14388//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14388//console
This message is automatically generated.
> Replace HTable with Table in client tests
> -----------------------------------------
>
> Key: HBASE-13893
> URL: https://issues.apache.org/jira/browse/HBASE-13893
> Project: HBase
> Issue Type: Bug
> Components: Client, test
> Reporter: Jurriaan Mous
> Assignee: Jurriaan Mous
> Attachments: HBASE-13893.patch
>
>
> Many client tests reference the HTable implementation instead of the generic
> Table implementation. It is now not possible to reuse the tests for another
> Table implementation. This issue focusses on all HTable instances in relevant
> client tests and thus not all HTable instances.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
