[
https://issues.apache.org/jira/browse/HBASE-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591663#comment-14591663
]
Bhupendra Kumar Jain commented on HBASE-13932:
----------------------------------------------
Few observations.
1) locations = new ArrayList<Path>();
>> Better initialize with size 2 (as of now only 2 locations)
2) fs.exists(mobFilePath)
>> exists call may be costly (Not very sure). Should we have cache for
>> mobFilePath.(Can be a HasHSet<Path> mobFileExistsCache)
Many of the cells may be pointing to same mobFilePath. We can utilize this
cache and avoid exists call.
3) String mobFileName = MobUtils.getMobFileName(cell);
>> Any chance that mobFileName becomes NULL or Empty String ? I think, the case
>> will not happen in practical until unless the hfile is corrupted. If the
>> case happens, then "new Path(location, mobFileName);" will throw
>> IllegalArgumentException. Do we need the NULL / Empty String check along
>> with Error printing.
Please excuse if observations are not correct.
> Add mob integrity check in HFilePrettyPrinter
> ---------------------------------------------
>
> Key: HBASE-13932
> URL: https://issues.apache.org/jira/browse/HBASE-13932
> Project: HBase
> Issue Type: Sub-task
> Components: mob
> Affects Versions: hbase-11339
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13932.patch
>
>
> We need to know whether a reference cell is dangling in mob. We can add this
> to HFilePrettyPrinter.
> We can add a new option to the command, to check the integrity of mob cells
> either per region or per file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
