[ 
https://issues.apache.org/jira/browse/HBASE-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593317#comment-14593317
 ] 

Bhupendra Kumar Jain commented on HBASE-13932:
----------------------------------------------

Thanks for addressing comments. New patch lgtm. 

Just one more change , can be done before commit.

1) evictMobFilesIfNecessary(foundMobFiles, 50);
>> foundMobFiles are initalized with 100. So limit should be 100 or initialize 
>> with 50

2) Query : As per current patch, cache scope is only per HFile. Can it be 
across HFile ( Global scope ) ?

> Add mob integrity check in HFilePrettyPrinter
> ---------------------------------------------
>
>                 Key: HBASE-13932
>                 URL: https://issues.apache.org/jira/browse/HBASE-13932
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mob
>    Affects Versions: hbase-11339
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: hbase-11339
>
>         Attachments: HBASE-13932-V2.patch, HBASE-13932.patch
>
>
> We need to know whether a reference cell is dangling in mob. We can add this 
> to HFilePrettyPrinter.
> We can add a new option to the command, to check the integrity of mob cells 
> either per region or per file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to