[
https://issues.apache.org/jira/browse/HBASE-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597152#comment-14597152
]
ramkrishna.s.vasudevan commented on HBASE-13932:
------------------------------------------------
LGTM. Just minor nit
bq. options.addOption("i", "checkMob", false, "Print all cells whose mob files
are missing");
The option i is to indicate the integrity of mob? Or should it be 'm' to say
that checkMob?
bq. Iterator<String> fnir = mobFileNames.iterator();
Can this be fileNamesItr? Rest looks good to me. +1.
> Add mob integrity check in HFilePrettyPrinter
> ---------------------------------------------
>
> Key: HBASE-13932
> URL: https://issues.apache.org/jira/browse/HBASE-13932
> Project: HBase
> Issue Type: Sub-task
> Components: mob
> Affects Versions: hbase-11339
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13932-V2.patch, HBASE-13932-V3.patch,
> HBASE-13932.patch
>
>
> We need to know whether a reference cell is dangling in mob. We can add this
> to HFilePrettyPrinter.
> We can add a new option to the command, to check the integrity of mob cells
> either per region or per file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
