[
https://issues.apache.org/jira/browse/HBASE-13932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592874#comment-14592874
]
Jingcheng Du commented on HBASE-13932:
--------------------------------------
Thanks a lot for comments!
bq. Better initialize with size 2 (as of now only 2 locations)
Right, it's better to have a fixed size for list.
bq. Many of the cells may be pointing to same mobFilePath. We can utilize this
cache and avoid exists call.
That's right, I had the same thought, I can add a cache for these file names.
bq. Any chance that mobFileName becomes NULL or Empty String ? I think, the
case will not happen in practical until unless the hfile is corrupted. If the
case happens, then "new Path(location, mobFileName);" will throw
IllegalArgumentException. Do we need the NULL / Empty String check along with
Error printing.
I can add one more check to validate the cell value.
> Add mob integrity check in HFilePrettyPrinter
> ---------------------------------------------
>
> Key: HBASE-13932
> URL: https://issues.apache.org/jira/browse/HBASE-13932
> Project: HBase
> Issue Type: Sub-task
> Components: mob
> Affects Versions: hbase-11339
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Fix For: hbase-11339
>
> Attachments: HBASE-13932.patch
>
>
> We need to know whether a reference cell is dangling in mob. We can add this
> to HFilePrettyPrinter.
> We can add a new option to the command, to check the integrity of mob cells
> either per region or per file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
