[ 
https://issues.apache.org/jira/browse/HBASE-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629628#comment-14629628
 ] 

Ashish Singhi commented on HBASE-13954:
---------------------------------------

Attached patch for master branch which removes all the code related to 
getClosestRowOrBefore.
Removed the respective non-deprecated API from Region and Store class also as 
the interfaces are marked as LimitedPrivate(COPROC) which means they are not 
public and need not go through deprecation cycle process.
Removed a non-deprecated api from Memstore interface as well which should not 
be a problem as it marked for private audience.
I have deprecated setter and getter for the flag used for this API in Get class 
as it is marked for public audience, where setter does not do any operation and 
getter just returns false (default value).
I did not remove {{getClosestRowBefore}} operation from the acl matrix in the 
book, as it is still valid for other branches and we do not have any separate 
book for 2.0.0.
I modified the existing test cases to use reverse scan where ever the removed 
apis where referenced.
Searched for {{GetClosestRow}} in *.rb scripts found no occurrence.

Uploaded the patch in RB as well, https://reviews.apache.org/r/36544/
Please review.

> Remove HTableInterface#getRowOrBefore related server side code
> --------------------------------------------------------------
>
>                 Key: HBASE-13954
>                 URL: https://issues.apache.org/jira/browse/HBASE-13954
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13954.patch
>
>
> As part of HBASE-13214 review, [~anoop.hbase] had a review comment on the 
> review board to remove all the server side related code for getRowOrBefore.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to