[ 
https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696479#comment-14696479
 ] 

stack commented on HBASE-14144:
-------------------------------

bq. So 'Fake' term is correct is what I think.

>From google define:fake
{code}
fake1
fāk/Submit
noun
1.
a thing that is not genuine; a forgery or sham.
"the painting was a fake"
synonyms:       forgery, counterfeit, copy, pirate(d) copy, sham, fraud, hoax, 
imitation, mock-up, dummy, reproduction; More
adjective
1.
not genuine; counterfeit.
"fake designer clothing"
synonyms:       forgery, counterfeit, copy, pirate(d) copy, sham, fraud, hoax, 
imitation, mock-up, dummy, reproduction; More
verb
1.
forge or counterfeit (something).
"the woman faked her spouse's signature"
synonyms:       forge, counterfeit, falsify, mock up, copy, pirate, reproduce, 
replicate; More
{code}

You already changed all other instances of fake. To be consistent I'd think you 
undo this one too.

Maybe a better name for this abstract class that is all about returning empty 
byte buffers is EmptyByteBufferedCell.


> Bloomfilter path to work with Byte buffered cells
> -------------------------------------------------
>
>                 Key: HBASE-14144
>                 URL: https://issues.apache.org/jira/browse/HBASE-14144
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14144.patch, HBASE-14144_1.patch, 
> HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, 
> HBASE-14144_5.patch
>
>
> This JIRA is to check if there will be a need to make the bloom filters to 
> work with ByteBuffer cells. During POC this path created lot of duplicated 
> code but considering other refactorings done in this path  may lead to less 
> duplication. This JIRA is a placeholder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to