[ 
https://issues.apache.org/jira/browse/HBASE-14144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696507#comment-14696507
 ] 

stack commented on HBASE-14144:
-------------------------------

bq. Intention was not to argue, just to tell what I felt.

Didn't think otherwise Ram!

Classes called 'fake' though they have a strong character -- i.e. they are the 
first on the row, or they return empty buffers no matter what -- and can be 
instantiated as actual, non-fake classes seemed off. Comments are not exactly 
right either in their use of fake but I get the gist and these are less 
important I'd say.

+1 to commit new renames.



> Bloomfilter path to work with Byte buffered cells
> -------------------------------------------------
>
>                 Key: HBASE-14144
>                 URL: https://issues.apache.org/jira/browse/HBASE-14144
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-14144.patch, HBASE-14144_1.patch, 
> HBASE-14144_2.patch, HBASE-14144_3.patch, HBASE-14144_4.patch, 
> HBASE-14144_5.patch
>
>
> This JIRA is to check if there will be a need to make the bloom filters to 
> work with ByteBuffer cells. During POC this path created lot of duplicated 
> code but considering other refactorings done in this path  may lead to less 
> duplication. This JIRA is a placeholder.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to