[
https://issues.apache.org/jira/browse/HBASE-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199991#comment-15199991
]
Ted Yu commented on HBASE-14123:
--------------------------------
For Backup.proto :
{code}
+ required uint32 bandwidth = 15;
{code}
I think convention is to use long for bandwidth.
e.g.
{code}
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java:
long bandwidth =
this.conf.getLong("replication.source.per.peer.node.bandwidth
{code}
{code}
- String targetRootDir) throws IOException {
+ String targetRootDir, int workers, int bandwidth) throws IOException {
{code}
Suggest using long for bandwidth.
{code}
+ opt.addOption("n", true, "History length");
{code}
I don't see "h" or "n" taken in BackupDriver. Either one is more user friendly.
> HBase Backup/Restore Phase 2
> ----------------------------
>
> Key: HBASE-14123
> URL: https://issues.apache.org/jira/browse/HBASE-14123
> Project: HBase
> Issue Type: Umbrella
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Attachments: HBASE-14123-v1.patch, HBASE-14123-v10.patch,
> HBASE-14123-v11.patch, HBASE-14123-v12.patch, HBASE-14123-v2.patch,
> HBASE-14123-v3.patch, HBASE-14123-v4.patch, HBASE-14123-v5.patch,
> HBASE-14123-v6.patch, HBASE-14123-v7.patch, HBASE-14123-v9.patch
>
>
> Phase 2 umbrella JIRA. See HBASE-7912 for design document and description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
