[
https://issues.apache.org/jira/browse/HBASE-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201797#comment-15201797
]
Ted Yu commented on HBASE-14123:
--------------------------------
{code}
+ List<BackupImage> list = new ArrayList<BackupImage>();
+ list.add(manifest.getBackupImage());
+ List<BackupImage> depList = manifest.getDependentListByTable(table);
+ list.addAll(depList);
TreeSet<BackupImage> restoreList =
- new TreeSet<BackupImage>(manifest.getDependentListByTable(table));
+ new TreeSet<BackupImage>(list);
{code}
Consider constructing TreeSet and adding BackupImage's to it without using List.
{code}
+ public void cancelCopyJob(byte[] jobId) throws IOException {
...
+ if (job == null) {
+ LOG.error("No job found for " + id);
+ // should we throw exception
+ }
{code}
Should return type be boolean so that the caller knows whether the cancellation
is effective ?
{code}
+ } catch (InterruptedException e) {
+ throw new IOException(e);
{code}
throw InterruptedIOException instead
{code}
+ { logDirs, tableNames[i].getNameAsString(),
newTableNames[i].getNameAsString()/*,
+ "-Dwal.bulk.output=" + bulkOutputPath.toString() */};
{code}
Consider referring to WALPlayer#BULK_OUTPUT_CONF_KEY directly.
> HBase Backup/Restore Phase 2
> ----------------------------
>
> Key: HBASE-14123
> URL: https://issues.apache.org/jira/browse/HBASE-14123
> Project: HBase
> Issue Type: Umbrella
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Attachments: HBASE-14123-v1.patch, HBASE-14123-v10.patch,
> HBASE-14123-v11.patch, HBASE-14123-v12.patch, HBASE-14123-v2.patch,
> HBASE-14123-v3.patch, HBASE-14123-v4.patch, HBASE-14123-v5.patch,
> HBASE-14123-v6.patch, HBASE-14123-v7.patch, HBASE-14123-v9.patch
>
>
> Phase 2 umbrella JIRA. See HBASE-7912 for design document and description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
