[
https://issues.apache.org/jira/browse/HBASE-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708278#comment-15708278
]
Anoop Sam John commented on HBASE-17191:
----------------------------------------
Yep. Only difference is that in case of we have a Codec in RPC and so we make
the cellblock, we just copy the cell over to N BBs and create the cell block.
So it is one copy.. When we dont make cell block, we will have to include the
cell data as part of the response PB message itself. So convert Cell pojo into
Cell PB objects and here itself one copy. And then the PB builder build a
message and write to COS. So again one more copy.. This patch will avoid the
1st copy. This is good.
> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in
> PBUtil#toCell(Cell cell)
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-17191
> URL: https://issues.apache.org/jira/browse/HBASE-17191
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
>
> Since we now have support for BBs in
> UnsafeByteOperations#unsafeWrap(ByteBuffer) . So for the non - java clients
> while creating the PB result we could avoid the copy to an temp array.
> Since we have a support to write to BB in ByteOutput having a result backed
> by Bytebuffer should be fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
