Anoop Sam John commented on HBASE-17191:

U mean we can not access CellUtil , which is in hbase-common within 
hbase-shaded-protobuf package?  I can see as of now there is no dependency on 
hbase-common but nothing stops from doing that no?
Any way I dont think we should add PB specific code into CellUtil. So +1 on 
having this check in PBUtil class..  We normally add this check into util 
places. Mostly CellUtil..  One patch I am trying to add to TagUtil also.  So no 
issue at all adding to PBUtil.  Any work in PB area, we can make sure the check 
and code is in this PBUtil.

> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in 
> PBUtil#toCell(Cell cell)
> ------------------------------------------------------------------------------------------
>                 Key: HBASE-17191
>                 URL: https://issues.apache.org/jira/browse/HBASE-17191
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
> Since we now have support for BBs in 
> UnsafeByteOperations#unsafeWrap(ByteBuffer) . So for the non - java clients 
> while creating the PB result we could avoid the copy to an temp array. 
> Since we have a support to write to BB in ByteOutput having a result backed 
> by Bytebuffer should be fine. 

This message was sent by Atlassian JIRA

Reply via email to