[
https://issues.apache.org/jira/browse/HBASE-17191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15708286#comment-15708286
]
ramkrishna.s.vasudevan commented on HBASE-17191:
------------------------------------------------
bq. When we dont make cell block, we will have to include the cell data as part
of the response PB message itself. So convert Cell pojo into Cell PB objects
and here itself one copy. And then the PB builder build a message and write to
COS. So again one more copy..
Ya that I got. So I was just confirming if in this case where we are sure that
non-java cases we will do a copy for creating the cell data I thought may be we
are not handling the callback for non-java cases.
> Make use of UnsafeByteOperations#unsafeWrap(ByteBuffer buffer) in
> PBUtil#toCell(Cell cell)
> ------------------------------------------------------------------------------------------
>
> Key: HBASE-17191
> URL: https://issues.apache.org/jira/browse/HBASE-17191
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
>
> Since we now have support for BBs in
> UnsafeByteOperations#unsafeWrap(ByteBuffer) . So for the non - java clients
> while creating the PB result we could avoid the copy to an temp array.
> Since we have a support to write to BB in ByteOutput having a result backed
> by Bytebuffer should be fine.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
