[ 
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15794779#comment-15794779
 ] 

Yu Li commented on HBASE-17372:
-------------------------------

Thanks for the ping [~Apache9]. The latest v3 patch lgtm, good clean up, +1.

Maybe we should mention the newly added OperationConfig in description and add 
some release note talking about how to set the (bunch of) timeout 
configurations?

In current stable releases we mainly use three timeouts: hbase.rpc.timeout for 
each RPC, hbase.client.operation.timeout for all operations but scan, and 
hbase.client.scanner.timeout.period for scan; And in 2.0 we've added 
hbase.rpc.read.timeout and hbase.rpc.write.timeout. However, I failed to find 
any detailed doc in our hbase book (please refer me to it if any, thanks), so 
maybe this is a good chance to add it (smile).

> Make AsyncTable thread safe
> ---------------------------
>
>                 Key: HBASE-17372
>                 URL: https://issues.apache.org/jira/browse/HBASE-17372
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17372-v1.patch, HBASE-17372-v2.patch, 
> HBASE-17372-v3.patch, HBASE-17372.patch
>
>
> The most methods are already thread safe. The problem is that we have some 
> methods that used to set timeout, we need to remove these methods and add a 
> parameter for each call to specific timeout settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to