[
https://issues.apache.org/jira/browse/HBASE-17372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795948#comment-15795948
]
stack commented on HBASE-17372:
-------------------------------
Patch looks good. Nice cleanup. Only downside is extra API but I think now with
operationconfig., we are done. It is generic so can add options to it if
needed. I think it looks good and makes more sense than setting general rpc
read/write timeouts for the table.
What is happening in AsyncConnectionConfiguration? We are setting rpc timeout,
rpc read timeout and rpc write timeout but we only have a getRpcTimeoutNs?
Should I get the builder on the OperationConfig obect rather than
AsyncTableBase?
OperationConfigBuilder newOperationConfig();
It could take a configuration when you ask for the builder so you can set
deafaults.
> Make AsyncTable thread safe
> ---------------------------
>
> Key: HBASE-17372
> URL: https://issues.apache.org/jira/browse/HBASE-17372
> Project: HBase
> Issue Type: Sub-task
> Components: asyncclient, Client
> Affects Versions: 2.0.0
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Fix For: 2.0.0
>
> Attachments: HBASE-17372-v1.patch, HBASE-17372-v2.patch,
> HBASE-17372-v3.patch, HBASE-17372.patch
>
>
> The most methods are already thread safe. The problem is that we have some
> methods that used to set timeout, we need to remove these methods and add a
> parameter for each call to specific timeout settings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
