[ 
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800723#comment-15800723
 ] 

Eshcar Hillel commented on HBASE-17407:
---------------------------------------

Thanks [~stack] your explanation is very helpful (but for some reason the 
comment was deleted).
I think it was important to understand that in the current state there is no 
danger of data loss.
Code maintainability is also important.
I can replace finalizeFlush with a preFlushSeqIDEstimation() which returns a 
lower bound on the sequence id that is invoked before we start the flush. The 
value returned by this method can be used to create the map [~Apache9] 
suggested.

Just one more question:
You say WAL truncation cannot be triggered during a flush. 
Can the map in seq accounting be reported to master during a flush?

> Correct update of maxFlushedSeqId in HRegion
> --------------------------------------------
>
>                 Key: HBASE-17407
>                 URL: https://issues.apache.org/jira/browse/HBASE-17407
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eshcar Hillel
>
> The attribute maxFlushedSeqId in HRegion is used to track the max sequence id 
> in the store files and is reported to HMaster. When flushing only part of the 
> memstore content this value might be incorrect and may cause data loss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to