[jira] [Commented] (HBASE-17407) Correct update of maxFlushedSeqId in HRegion

[Duo Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831348#comment-15831348
 ] 

Duo Zhang commented on HBASE-17407:
-----------------------------------

Let's just remove the old startCacheFlush method? The WAL interface is marked 
as @InterfaceAudience.Private.

And mind explaining this change?
{quote}
     if (flushing != null) {
       for (Map.Entry<ImmutableByteArray, Long> e : flushing.entrySet()) {
         Long currentId = tmpMap.get(e.getKey());
-        if (currentId != null && currentId.longValue() <= 
e.getValue().longValue()) {
+        if (currentId != null && currentId.longValue() < 
e.getValue().longValue()) {
{quote}

Why changing '<=' to '<' ?

Thanks.

> Correct update of maxFlushedSeqId in HRegion
> --------------------------------------------
>
>                 Key: HBASE-17407
>                 URL: https://issues.apache.org/jira/browse/HBASE-17407
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Eshcar Hillel
>         Attachments: HBASE-17407-V01.patch, HBASE-17407-V01.patch, 
> HBASE-17407-V02.patch
>
>
> The attribute maxFlushedSeqId in HRegion is used to track the max sequence id 
> in the store files and is reported to HMaster. When flushing only part of the 
> memstore content this value might be incorrect and may cause data loss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)