[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833445#comment-15833445
]
Eshcar Hillel commented on HBASE-17407:
---------------------------------------
bq. Let's just remove the old startCacheFlush method?
I think removing the startCacheFlush method may have consequences which are
beyond the scope of this Jira. I'm not sure it removing it would be the right
thing, but if you feel strongly about it then Let's discuss it in a dedicated
issue.
bq. Why changing '<=' to '<' ?
We would like to prevent the WAL from going backward, but no harm is done if it
stays the same.
Specifically, with the current fix in case of EAGER compaction policy the
returned sequence number is a lower bound estimation -- it just returns the
current minimum sequence number.
Most of the time the minimum sequence number will be larger than the previous
one. But there might be some cases (like in the first flush to disk) where it
is the same and therefore the change.
> Correct update of maxFlushedSeqId in HRegion
> --------------------------------------------
>
> Key: HBASE-17407
> URL: https://issues.apache.org/jira/browse/HBASE-17407
> Project: HBase
> Issue Type: Bug
> Reporter: Eshcar Hillel
> Attachments: HBASE-17407-V01.patch, HBASE-17407-V01.patch,
> HBASE-17407-V02.patch
>
>
> The attribute maxFlushedSeqId in HRegion is used to track the max sequence id
> in the store files and is reported to HMaster. When flushing only part of the
> memstore content this value might be incorrect and may cause data loss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
