[
https://issues.apache.org/jira/browse/HBASE-17407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833513#comment-15833513
]
Duo Zhang commented on HBASE-17407:
-----------------------------------
{quote}
I think removing the startCacheFlush method may have consequences which are
beyond the scope of this Jira. I'm not sure it removing it would be the right
thing, but if you feel strongly about it then Let's discuss it in a dedicated
issue.
{quote}
Fine. Can do it in another issue.
And for the '<=' to '<' change, I read the code again, it is only a check in
abortCacheFlush so not very critical.
+1 on patch v2. You can try another pre commit run to see if it can pass all
the UTs.
Thanks.
> Correct update of maxFlushedSeqId in HRegion
> --------------------------------------------
>
> Key: HBASE-17407
> URL: https://issues.apache.org/jira/browse/HBASE-17407
> Project: HBase
> Issue Type: Bug
> Reporter: Eshcar Hillel
> Assignee: Eshcar Hillel
> Attachments: HBASE-17407-V01.patch, HBASE-17407-V01.patch,
> HBASE-17407-V02.patch
>
>
> The attribute maxFlushedSeqId in HRegion is used to track the max sequence id
> in the store files and is reported to HMaster. When flushing only part of the
> memstore content this value might be incorrect and may cause data loss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
