[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016734#comment-16016734
]
Vincent Poon commented on HBASE-18060:
--------------------------------------
Put up a review at https://reviews.apache.org/r/59385/
Summary:
Changed java 8 syntax to java 8 equivalent (e.g. lambdas to anonymous inner
classes)
Wrote simple implementations of java 8 library features (instead of Map's
'compute', use "putIfAbsent" and AtomicLong)
copied in LongAdder/Striped64 code
We don't have HADOOP-10839 in branch-1, so used reflection to unregister hadoop
metric sources. Added a unit test for that.
> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection
> for coprocessors
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18060
> URL: https://issues.apache.org/jira/browse/HBASE-18060
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Attachments: HBASE-18060.branch-1.v1.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for
> coprocessors to report custom metrics through HBase is useful for us, and if
> we have coprocessors use the native API, a re-write won't be necessary after
> an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features. Seems we can work around this as
> most of it is syntactic sugar. Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not
> sure if these can coexist just for this feature
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
