[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017974#comment-16017974
]
Hadoop QA commented on HBASE-18060:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s
{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} @author {color} | {color:red} 0m 0s
{color} | {color:red} The patch appears to contain 1 @author tags which the
community has agreed to not allow in code contributions. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 14 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
13s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 36s
{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 18s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
43s {color} | {color:green} branch-1 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
4s {color} | {color:green} branch-1 passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source:
hbase-assembly hbase-assembly . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 0s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 56s
{color} | {color:red} hbase-server in branch-1 has 1 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 6s
{color} | {color:green} branch-1 passed with JDK v1.8.0_131 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m 36s
{color} | {color:green} branch-1 passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m 51s
{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 14s
{color} | {color:red} hbase-assembly in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 8s
{color} | {color:red} root in the patch failed with JDK v1.8.0_131. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 11s
{color} | {color:red} hbase-assembly in the patch failed with JDK v1.8.0_131.
{color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 14s
{color} | {color:green} hbase-common-jdk1.8.0_131 with JDK v1.8.0_131 generated
0 new + 10 unchanged - 10 fixed = 10 total (was 20) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 9s
{color} | {color:green} hbase-metrics-api in the patch passed with JDK
v1.8.0_131. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 9s
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK
v1.8.0_131. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 8s {color}
| {color:red} root in the patch failed with JDK v1.8.0_131. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 11s {color}
| {color:red} hbase-assembly in the patch failed with JDK v1.8.0_131. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s
{color} | {color:green} hbase-examples in the patch passed with JDK v1.8.0_131.
{color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 12s
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK
v1.8.0_131. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 10s {color}
| {color:red} hbase-metrics-jdk1.8.0_131 with JDK v1.8.0_131 generated 8 new +
0 unchanged - 0 fixed = 8 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 36s
{color} | {color:green} hbase-server-jdk1.8.0_131 with JDK v1.8.0_131 generated
0 new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 1m 9s
{color} | {color:red} root in the patch failed with JDK v1.7.0_80. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 15s
{color} | {color:red} hbase-assembly in the patch failed with JDK v1.7.0_80.
{color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s
{color} | {color:green} hbase-common-jdk1.7.0_80 with JDK v1.7.0_80 generated 0
new + 10 unchanged - 10 fixed = 10 total (was 20) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 10s
{color} | {color:green} hbase-metrics-api in the patch passed with JDK
v1.7.0_80. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 11s
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK
v1.7.0_80. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 9s {color}
| {color:red} root in the patch failed with JDK v1.7.0_80. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 15s {color}
| {color:red} hbase-assembly in the patch failed with JDK v1.7.0_80. {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 15s
{color} | {color:green} hbase-examples in the patch passed with JDK v1.7.0_80.
{color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 12s
{color} | {color:green} hbase-hadoop2-compat in the patch passed with JDK
v1.7.0_80. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 12s {color}
| {color:red} hbase-metrics-jdk1.7.0_80 with JDK v1.7.0_80 generated 8 new + 0
unchanged - 0 fixed = 8 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 38s
{color} | {color:green} hbase-server-jdk1.7.0_80 with JDK v1.7.0_80 generated 0
new + 5 unchanged - 5 fixed = 5 total (was 10) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
29s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m 32s
{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvneclipse {color} | {color:red} 0m 16s
{color} | {color:red} hbase-assembly in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 3s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 27s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 50s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 7s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 31s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 53s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 19s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 40s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 58s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m 21s
{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 44s
{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} hbaseprotoc {color} | {color:red} 0m 17s
{color} | {color:red} hbase-assembly in the patch failed. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patched modules with no Java source: .
hbase-assembly {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
19s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s
{color} | {color:green} hbase-common-jdk1.8.0_131 with JDK v1.8.0_131 generated
0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} hbase-metrics-api in the patch passed with JDK
v1.8.0_131. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK
v1.8.0_131. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s
{color} | {color:green} root in the patch passed with JDK v1.8.0_131. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 6s
{color} | {color:green} hbase-assembly in the patch passed with JDK v1.8.0_131.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} hbase-examples in the patch passed with JDK v1.8.0_131.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} hbase-hadoop2-compat-jdk1.8.0_131 with JDK v1.8.0_131
generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} hbase-metrics in the patch passed with JDK v1.8.0_131.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 22s
{color} | {color:green} hbase-server-jdk1.8.0_131 with JDK v1.8.0_131 generated
0 new + 3 unchanged - 3 fixed = 3 total (was 6) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s
{color} | {color:green} hbase-common-jdk1.7.0_80 with JDK v1.7.0_80 generated 0
new + 4 unchanged - 4 fixed = 4 total (was 8) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s
{color} | {color:green} hbase-metrics-api in the patch passed with JDK
v1.7.0_80. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s
{color} | {color:green} hbase-hadoop-compat in the patch passed with JDK
v1.7.0_80. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 19s
{color} | {color:green} root in the patch passed with JDK v1.7.0_80. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} hbase-assembly in the patch passed with JDK v1.7.0_80.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s
{color} | {color:green} hbase-examples in the patch passed with JDK v1.7.0_80.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s
{color} | {color:green} hbase-hadoop2-compat-jdk1.7.0_80 with JDK v1.7.0_80
generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} hbase-metrics in the patch passed with JDK v1.7.0_80.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s
{color} | {color:green} hbase-server-jdk1.7.0_80 with JDK v1.7.0_80 generated 0
new + 3 unchanged - 3 fixed = 3 total (was 6) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 45s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 11s
{color} | {color:green} hbase-metrics-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s
{color} | {color:green} hbase-hadoop-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 32s {color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 13s {color}
| {color:red} hbase-assembly in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 18s
{color} | {color:green} hbase-examples in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s
{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 15s
{color} | {color:green} hbase-metrics in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 17s {color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
29s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 118m 54s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.TestInterfaceAudienceAnnotations |
| | hadoop.hbase.ipc.TestSimpleRpcScheduler |
| | hadoop.hbase.ipc.TestSimpleRpcScheduler |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:58c504e |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12869026/HBASE-18060.branch-1.v2.patch
|
| JIRA Issue | HBASE-18060 |
| Optional Tests | asflicense javac javadoc unit xml compile findbugs
hadoopcheck hbaseanti checkstyle |
| uname | Linux ff87f0ad455d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | branch-1 / 300c538 |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_131
/usr/lib/jvm/java-7-oracle:1.7.0_80 |
| @author |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/author-tags.txt
|
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-mvninstall-root.txt
|
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-mvninstall-hbase-assembly.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-hbase-assembly-jdk1.8.0_131.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-root-jdk1.8.0_131.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-hbase-assembly-jdk1.8.0_131.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/diff-compile-javac-hbase-metrics-jdk1.8.0_131.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-root-jdk1.7.0_80.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-hbase-assembly-jdk1.7.0_80.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-root-jdk1.7.0_80.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-compile-hbase-assembly-jdk1.7.0_80.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/diff-compile-javac-hbase-metrics-jdk1.7.0_80.txt
|
| mvneclipse |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-mvneclipse-root.txt
|
| mvneclipse |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-mvneclipse-hbase-assembly.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-hbaseprotoc-root.txt
|
| hbaseprotoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-hbaseprotoc-hbase-assembly.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-unit-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-unit-hbase-assembly.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-unit-root.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/testReport/ |
| modules | C: hbase-common hbase-metrics-api hbase-hadoop-compat .
hbase-assembly hbase-examples hbase-hadoop2-compat hbase-metrics hbase-server
U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/6849/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection
> for coprocessors
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18060
> URL: https://issues.apache.org/jira/browse/HBASE-18060
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Attachments: HBASE-18060.branch-1.3.v1.patch,
> HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch,
> HBASE-18060.branch-1.v1.patch, HBASE-18060.branch-1.v2.patch,
> HBASE-18060.branch-1.v3.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for
> coprocessors to report custom metrics through HBase is useful for us, and if
> we have coprocessors use the native API, a re-write won't be necessary after
> an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features. Seems we can work around this as
> most of it is syntactic sugar. Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not
> sure if these can coexist just for this feature
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
