[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018261#comment-16018261
]
Enis Soztutar commented on HBASE-18060:
---------------------------------------
Also can you please add a comment to LongAdder and Striped64 that the source
code is from OpenJDK. Did we check that the license is compatible?
You said that branch-1 depends on an older version of dropwizard metrics. Is
this new dependency fine coexisting with the old dep?
{code}
<dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>3.1.2</version>
+ </dependency>
{code}
I've skimmed the changes, rest seems fine.
> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection
> for coprocessors
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18060
> URL: https://issues.apache.org/jira/browse/HBASE-18060
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Attachments: HBASE-18060.branch-1.3.v1.patch,
> HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch,
> HBASE-18060.branch-1.v1.patch, HBASE-18060.branch-1.v2.patch,
> HBASE-18060.branch-1.v3.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for
> coprocessors to report custom metrics through HBase is useful for us, and if
> we have coprocessors use the native API, a re-write won't be necessary after
> an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features. Seems we can work around this as
> most of it is syntactic sugar. Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not
> sure if these can coexist just for this feature
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
