[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017845#comment-16017845
]
Andrew Purtell commented on HBASE-18060:
----------------------------------------
I think LongAdder / Striped64 should be placed into hbase-common.
Have you tried running the API compatibility checker (HBASE-12808) before and
after this change to get its analysis of the ramifications? Might be useful. It
can be finicky so if you decide to try but cannot get it to work within a
reasonable amount of time please ping me and I'll give it a shot.
How much bigger is the distribution tarball with the new dependencies? Maybe we
need followup to add exclusions. Would be a master patch first, then a backport
on top of this work, if needed.
I don't know what happened here but this has to go, and we need a patch to
master to remove it there as well:
{code}
+ * Copyright 2016 Josh Elser
{code}
[~elserj]
Skimmed the changes mostly. Looks good as a backport.
> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection
> for coprocessors
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18060
> URL: https://issues.apache.org/jira/browse/HBASE-18060
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Attachments: HBASE-18060.branch-1.3.v1.patch,
> HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch,
> HBASE-18060.branch-1.v1.patch, HBASE-18060.branch-1.v2.patch,
> HBASE-18060.branch-1.v3.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for
> coprocessors to report custom metrics through HBase is useful for us, and if
> we have coprocessors use the native API, a re-write won't be necessary after
> an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features. Seems we can work around this as
> most of it is syntactic sugar. Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not
> sure if these can coexist just for this feature
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
