[
https://issues.apache.org/jira/browse/HBASE-18060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019865#comment-16019865
]
Vincent Poon commented on HBASE-18060:
--------------------------------------
The LongAdder/Striped64 are from public domain. There is a note at the top
that says it's released to public domain, with a link to Creative Commons
public domain license.
[~apurtell] , I moved LongAdder / Striped64 into hbase-common. Ran the API
compatibility checker, it complained about removed methods in
FastLongHistogram, but that was just because that classed was moved from
hbase-common to hbase-metrics. It also noted added method getMetricRegistry* ,
which should be fine. The new tarball is 74m, the same as before. Inside the
lib folder, the additions are metrics-core-3.1.2.jar (dropwizard),
hbase-metrics.jar and hbase-metrics-api.jar. They are 110k, 29k, and 22k,
respectively.
[~enis] Thanks for pointing out that concurrency issue, I changed the
RefCountingMap#put and #remove to synchronize on the map, can you take a look?
As for the dropwizard addition, I think it should coexist fine because they
actually changed all the packaging in dropwizard to com.codahale.* , whereas
before it was yammer. So there shouldn't be conflicts. I deployed to a
cluster after writing some test coprocessor metrics and it all worked fine.
> Backport to branch-1 HBASE-9774 HBase native metrics and metric collection
> for coprocessors
> -------------------------------------------------------------------------------------------
>
> Key: HBASE-18060
> URL: https://issues.apache.org/jira/browse/HBASE-18060
> Project: HBase
> Issue Type: New Feature
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Attachments: HBASE-18060.branch-1.3.v1.patch,
> HBASE-18060.branch-1.3.v2.patch, HBASE-18060.branch-1.3.v3.patch,
> HBASE-18060.branch-1.3.v4.patch, HBASE-18060.branch-1.v1.patch,
> HBASE-18060.branch-1.v2.patch, HBASE-18060.branch-1.v3.patch,
> HBASE-18060.branch-1.v4.patch
>
>
> I'd like to explore backporting HBASE-9774 to branch-1, as the ability for
> coprocessors to report custom metrics through HBase is useful for us, and if
> we have coprocessors use the native API, a re-write won't be necessary after
> an upgrade to 2.0.
> The main issues I see so far are:
> - the usage of Java 8 language features. Seems we can work around this as
> most of it is syntactic sugar. Will need to find a backport for LongAdder
> - dropwizard 3.1.2 in Master. branch-1 is still on yammer metrics 2.2. Not
> sure if these can coexist just for this feature
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
