[
https://issues.apache.org/jira/browse/HBASE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202686#comment-16202686
]
Josh Elser commented on HBASE-18901:
------------------------------------
bq. Shouldn't we remove the current Makefile in this patch as well? Cmake will
create the makefile, no?
Yup, my bad. Meant to do that, and apparently forgot to do the {{git rm}}
bq. In HBASE-18727, we explicitly removed the JNI dependency from the main
libHBaseClient build. That is why the headers under test-util stayed in the src
directory instead of the include dir. Are we requiring libjni with this build?
I do know that CMake would fail for me with only a JRE installed about JNI
stuff. This might be an unintended regression.
bq. Remove this line, instead of commenting out?
Let me nuke that too.
bq. Get rid of buck based build, and all of the BUCK files, etc.
And this too.
Will leave the other ones to Marc to give some feedback on at his leisure.
> Support build with CMake
> ------------------------
>
> Key: HBASE-18901
> URL: https://issues.apache.org/jira/browse/HBASE-18901
> Project: HBase
> Issue Type: Sub-task
> Reporter: Josh Elser
> Assignee: marco polo
> Labels: C++
> Fix For: HBASE-14850
>
> Attachments: HBASE-18901.v1.HBASE-14850.patch,
> HBASE-18901.v2.HBASE-14850.patch, HBASE-18901.v3.HBASE-14850.patch
>
>
> I've co-opted some help from folks in trying to support CMake as the build
> tool instead of Buck.
> They have something working, but need to consolidate the patch. Filing an
> issue for them to put a patch on.
> FYI [~enis], [~tedyu]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
