[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250632#comment-16250632
 ] 

Chia-Ping Tsai commented on HBASE-19235:
----------------------------------------

bq. I misunderstood the suggestion above. BaseEnvironment is internal... yeah, 
could be good to refer directly to it internally.
I try to avoid the instanceof checks.

bq. if we should allow it so super class can have different IA from subclass. 
Suggested we take that up elsewhere, especially if we can turn up another 
example where a super IA.Private when children are IA.LP or public would be 
convenient.
It makes sense to me that sub-class can always narrow the declaration (ex. 
IA.Public -> IA.Private/IA.LP). Widening the declaration is like a issue we 
need to fix. 

> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
>                 Key: HBASE-19235
>                 URL: https://issues.apache.org/jira/browse/HBASE-19235
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to