[
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250785#comment-16250785
]
Anoop Sam John commented on HBASE-19235:
----------------------------------------
Appy. IMHO #2 is not at all good. Am not sure any other place we have like
super interface is private and sub type as LP or public. I did not check. If
so, we have to fix. I raised this issue after seeing a patch in Phoenix. The
sub interfaces are LP exposed. So any functions available to it, can be called
by user. Else the CP user has to really check in which interface it is
declared and see its declaration. It will be very difficult task and confusing
for sure.
Ya we were having CPEnv interface as private till now. But we can cleanup now.
Better late than never.
I understood Chia comment to avoid the instance of check. Let me see. I thought
we can make it simple. Like in old way. Let me see.
> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Affects Versions: 2.0.0-alpha-4
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with
> LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions
> in this are. Better we mark CoprocessorEnvironment also as CP exposed to
> avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
